samples(storage): add samples for bucket encryption encoforcement config#16045
samples(storage): add samples for bucket encryption encoforcement config#16045bajajneha27 wants to merge 1 commit intogoogleapis:mainfrom
Conversation
product-auto-label
bot
added
api: storage
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces new C++ samples for the Google Cloud Storage client library, specifically focusing on managing bucket encryption enforcement configurations. These examples provide practical demonstrations of how to programmatically interact with and control the encryption policies for storage buckets, covering operations like retrieving current settings, applying new enforcement rules, and clearing existing configurations. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds new samples for managing bucket encryption enforcement configurations. The changes are well-structured and the new sample code correctly demonstrates the usage of the API. All original comments have been retained as they align with general C++ best practices and the Google C++ Style Guide, and none of the provided rules contradict them.
| std::cout << "\nCreating bucket to run the example (" << bucket_name << ")" | ||
| << std::endl; |
There was a problem hiding this comment.
Per the Google C++ Style Guide, you should use \n instead of std::endl. std::endl also flushes the stream, which is often unnecessary and can impact performance.
std::cout << "\nCreating bucket to run the example (" << bucket_name << ")\n";References
- The repository style guide defers to the Google C++ Style Guide, which states to use
\ninstead ofstd::endlto avoid performance issues with flushing the stream. (link)
| std::cout << "\nRunning the SetBucketEncryptionEnforcementConfig() example" | ||
| << std::endl; |
There was a problem hiding this comment.
Per the Google C++ Style Guide, you should use \n instead of std::endl. std::endl also flushes the stream, which is often unnecessary and can impact performance.
std::cout << "\nRunning the SetBucketEncryptionEnforcementConfig() example\n";References
- The repository style guide defers to the Google C++ Style Guide, which states to use
\ninstead ofstd::endlto avoid performance issues with flushing the stream. (link)
| std::cout << "\nRunning the GetBucketEncryptionEnforcementConfig() example [1]" | ||
| << std::endl; |
There was a problem hiding this comment.
Per the Google C++ Style Guide, you should use \n instead of std::endl. std::endl also flushes the stream, which is often unnecessary and can impact performance.
std::cout << "\nRunning the GetBucketEncryptionEnforcementConfig() example [1]\n";References
- The repository style guide defers to the Google C++ Style Guide, which states to use
\ninstead ofstd::endlto avoid performance issues with flushing the stream. (link)
| std::cout << "\nRunning the RemoveAllEncryptionEnforcementConfig() example" | ||
| << std::endl; |
There was a problem hiding this comment.
Per the Google C++ Style Guide, you should use \n instead of std::endl. std::endl also flushes the stream, which is often unnecessary and can impact performance.
std::cout << "\nRunning the RemoveAllEncryptionEnforcementConfig() example\n";References
- The repository style guide defers to the Google C++ Style Guide, which states to use
\ninstead ofstd::endlto avoid performance issues with flushing the stream. (link)
| std::cout << "\nRunning the GetBucketEncryptionEnforcementConfig() example [2]" | ||
| << std::endl; |
There was a problem hiding this comment.
Per the Google C++ Style Guide, you should use \n instead of std::endl. std::endl also flushes the stream, which is often unnecessary and can impact performance.
std::cout << "\nRunning the GetBucketEncryptionEnforcementConfig() example [2]\n";References
- The repository style guide defers to the Google C++ Style Guide, which states to use
\ninstead ofstd::endlto avoid performance issues with flushing the stream. (link)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16045 +/- ##
==========================================
- Coverage 92.66% 92.66% -0.01%
==========================================
Files 2341 2342 +1
Lines 215695 215773 +78
==========================================
+ Hits 199876 199940 +64
- Misses 15819 15833 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
No description provided.