impl(testing_util): include algorithm header#16044
Conversation
`google/cloud/testing_util/command_line_parsing.cc` appears to use `std::transform` without including `<algorithm>`. We encountered this in Nixpkgs; you can see some example build logs at the bottom of https://hydra.nixos.org/build/323365915/log. I'm not *quite* sure of the root cause of this error appearing now (it may be related to GCC 15), but I believe this is nonetheless a correct change.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a build failure in Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the <algorithm> header to google/cloud/testing_util/command_line_parsing.cc. This change addresses a missing include for std::transform, which was causing build failures with some toolchains. The change is correct and I have no further feedback.
|
/gcbrun |
|
Hm, I'm looking at the failed xsan-pr run, and the failure seems unrelated (or at least I can't imagine why this PR would cause it). Is this expected/something I need to fix? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16044 +/- ##
==========================================
- Coverage 92.65% 92.65% -0.01%
==========================================
Files 2339 2339
Lines 215290 215290
==========================================
- Hits 199482 199474 -8
- Misses 15808 15816 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 participants
google/cloud/testing_util/command_line_parsing.ccappears to usestd::transformwithout including<algorithm>. We encountered this in Nixpkgs; you can see some example build logs at the bottom of https://hydra.nixos.org/build/323365915/log (though that is on a somewhat older version, I believe we hit the same issue on a newer version). I'm not quite sure of the root cause of this error appearing now (it may be related to GCC 15), but I believe this is nonetheless a correct change.