Add stopFirst option to stop services before running dependencies#1394
Open
RodrigoHamuy wants to merge 3 commits intogoogle:mainfrom
Open
Add stopFirst option to stop services before running dependencies#1394RodrigoHamuy wants to merge 3 commits intogoogle:mainfrom
RodrigoHamuy wants to merge 3 commits intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
WIP: adds early adoptee stop logic in _execute(); will be gated behind a per-dependency flag (name TBD, e.g. preStop) before finalising. https://claude.ai/code/session_01Be7upyt3ZRNdHuhyi1W7eF
Introduces a new per-dependency boolean option `stopFirst` (default: false).
When true on a dependency of a service, the running service (adoptee) is
stopped before that dependency executes. This allows dependencies to freely
write files the service may have open, avoiding file-lock and port conflicts
on both Unix and Windows.
Usage:
"dependencies": [{"script": "build", "cascade": true, "stopFirst": true}]
https://claude.ai/code/session_01Be7upyt3ZRNdHuhyi1W7eF
e06169f to
e658140
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new
stopFirstconfiguration option for script dependencies that allows stopping a running service before executing a dependency. This is useful when a dependency needs to write files that the service currently has open.Key Changes
stopFirstboolean property to dependency configuration with documentation explaining its purposestopFirst: booleanfield to theDependencyinterfacestopFirstproperty from configurationstopFirstis a boolean value, reporting errors if invalidstopFirstvalue to the dependency configurationstopFirst: truebefore executing dependenciesImplementation Details
stopFirstoption defaults tofalseto maintain backward compatibilitystopFirst: true, the service is stopped before that dependency runs, allowing the dependency to freely write to files