updated remaining modules to use request helpers#202
Open
mihirvala08 wants to merge 3 commits intomainfrom
Open
updated remaining modules to use request helpers#202mihirvala08 wants to merge 3 commits intomainfrom
mihirvala08 wants to merge 3 commits intomainfrom
Conversation
Collaborator
Author
|
@PaperMtn Feel free to review changes and let me know if you find any improvement or miss. |
Contributor
|
@mihirvala08 I've got a few minor changes based on some other standardisation and refactoring I was doing at the same time as moving over to the helpers. I can't modify this one, so I will open a new PR into this branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardize Return Types and Refactor Request Helpers
Overview
This PR addresses #149 by standardizing return types across all
list_*functions and introducing centralized request helper utilities to ensure consistent behavior throughout the Chronicle SDK.Changes
Module Refactoring
Chronicle modules have been refactored to use the centralized request helpers:
client.py- ChronicleClient core functionalitydashboard_query.py- Dashboard query operationsdata_export.py- Data export functionalitydata_table.py- Data table operationsentity.py- Entity managementfeeds.py- Feed operationsgemini.py- Gemini AI integrationinvestigations.py- Investigation managementioc.py- Indicator of Compromise handlinglog_ingest.py- Log ingestionlog_processing_pipelines.py- Log processing pipeline managementlog_types.py- Log type operationsnl_search.py- Natural language searchparser.py- Parser managementparser_extension.py- Parser extension handlingreference_list.py- Reference list operationsrule.py- Rule managementrule_alert.py- Rule alert handlingrule_detection.py- Rule detection operationsrule_exclusion.py- Rule exclusion managementrule_set.py- Rule set operationsTesting
Comprehensive test updates across all affected modules:
as_list=Trueandas_list=FalsemodesBreaking Changes
Migration Path: Users relying on dict return types should:
list_*function callsas_list=Falseparameter if they need the full response with metadataas_list=True(or default behavior changes)Related Issues
Fixes #149