Enable password reset for registrars#2971
Conversation
gbrodman
left a comment
There was a problem hiding this comment.
@gbrodman reviewed 3 files and all commit messages, and made 2 comments.
Reviewable status: 3 of 4 files reviewed, 2 unresolved discussions (waiting on ptkach).
console-webapp/src/app/shared/directives/userLevelVisiblity.directive.ts line 35 at r1 (raw file):
SUPPORT_LEAD: [], SUPPORT_AGENT: [], };
i think we may also need to remove the isAdmin check in the eppPasswordEdit.component.html file?
core/src/test/java/google/registry/ui/server/console/PasswordResetVerifyActionTest.java line 114 at r1 (raw file):
@Test @Disabled("Enable when testing is done in sandbox and isAdmin check is removed")
need to remove the import i think
gbrodman
left a comment
There was a problem hiding this comment.
@gbrodman reviewed 1 file.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ptkach).
d5b32f1 to
e249c93
Compare
ptkach
left a comment
There was a problem hiding this comment.
@ptkach made 2 comments.
Reviewable status: 3 of 6 files reviewed, 2 unresolved discussions (waiting on gbrodman).
console-webapp/src/app/shared/directives/userLevelVisiblity.directive.ts line 35 at r1 (raw file):
Previously, gbrodman wrote…
i think we may also need to remove the isAdmin check in the eppPasswordEdit.component.html file?
Right, thanks
core/src/test/java/google/registry/ui/server/console/PasswordResetVerifyActionTest.java line 114 at r1 (raw file):
Previously, gbrodman wrote…
need to remove the import i think
Yeah, though still not sure why it's happening automatically
gbrodman
left a comment
There was a problem hiding this comment.
@gbrodman reviewed 3 files and all commit messages, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ptkach).
gbrodman
left a comment
There was a problem hiding this comment.
@gbrodman resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ptkach).
This change is