Skip to content

Enable password reset for registrars#2971

Merged
ptkach merged 1 commit intogoogle:masterfrom
ptkach:consolePasswordResetEnable
Feb 27, 2026
Merged

Enable password reset for registrars#2971
ptkach merged 1 commit intogoogle:masterfrom
ptkach:consolePasswordResetEnable

Conversation

@ptkach
Copy link
Collaborator

@ptkach ptkach commented Feb 27, 2026

This change is Reviewable

@ptkach ptkach requested a review from gbrodman February 27, 2026 18:53
Copy link
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbrodman reviewed 3 files and all commit messages, and made 2 comments.
Reviewable status: 3 of 4 files reviewed, 2 unresolved discussions (waiting on ptkach).


console-webapp/src/app/shared/directives/userLevelVisiblity.directive.ts line 35 at r1 (raw file):

  SUPPORT_LEAD: [],
  SUPPORT_AGENT: [],
};

i think we may also need to remove the isAdmin check in the eppPasswordEdit.component.html file?


core/src/test/java/google/registry/ui/server/console/PasswordResetVerifyActionTest.java line 114 at r1 (raw file):

  @Test
  @Disabled("Enable when testing is done in sandbox and isAdmin check is removed")

need to remove the import i think

Copy link
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbrodman reviewed 1 file.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ptkach).

@ptkach ptkach force-pushed the consolePasswordResetEnable branch from d5b32f1 to e249c93 Compare February 27, 2026 19:14
Copy link
Collaborator Author

@ptkach ptkach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptkach made 2 comments.
Reviewable status: 3 of 6 files reviewed, 2 unresolved discussions (waiting on gbrodman).


console-webapp/src/app/shared/directives/userLevelVisiblity.directive.ts line 35 at r1 (raw file):

Previously, gbrodman wrote…

i think we may also need to remove the isAdmin check in the eppPasswordEdit.component.html file?

Right, thanks


core/src/test/java/google/registry/ui/server/console/PasswordResetVerifyActionTest.java line 114 at r1 (raw file):

Previously, gbrodman wrote…

need to remove the import i think

Yeah, though still not sure why it's happening automatically

Copy link
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbrodman reviewed 3 files and all commit messages, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ptkach).

Copy link
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbrodman resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ptkach).

@ptkach ptkach enabled auto-merge February 27, 2026 19:27
@ptkach ptkach added this pull request to the merge queue Feb 27, 2026
Merged via the queue into google:master with commit 186dd80 Feb 27, 2026
10 checks passed
@ptkach ptkach deleted the consolePasswordResetEnable branch February 27, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants