Skip to content

Upgrade to the new sqlcipher-android library#2938

Draft
Itskiprotich wants to merge 4 commits intogoogle:masterfrom
IntelliSOFT-Consulting:jk-sqlcipher-upgrade
Draft

Upgrade to the new sqlcipher-android library#2938
Itskiprotich wants to merge 4 commits intogoogle:masterfrom
IntelliSOFT-Consulting:jk-sqlcipher-upgrade

Conversation

@Itskiprotich
Copy link
Contributor

@Itskiprotich Itskiprotich commented Jan 21, 2026

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2892

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

  • Encrpted Database
output.mp4
  • Upgrade in an existing application
checklist_reporting_compressed.mp4

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@Itskiprotich Itskiprotich requested a review from a team as a code owner January 21, 2026 05:00
@Itskiprotich Itskiprotich requested review from MJ1998 and removed request for a team January 21, 2026 05:00
@github-project-automation github-project-automation bot moved this from New to PR under Review in Android FHIR SDK Jan 22, 2026
@Itskiprotich Itskiprotich marked this pull request as draft January 22, 2026 09:24
@jingtang10
Copy link
Collaborator

Also - can you please make sure to test this e2e with an existing db? If people upgrade their app their existing db will still need to work. This is not a schema change so probably doesn't require a db "migration" but we need to make sure the library works.

@Itskiprotich
Copy link
Contributor Author

Sure, @jingtang10. I'm doing some rounds of test. I'll attached videos to the PR description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: PR under Review

Development

Successfully merging this pull request may close these issues.

Potential issue with 16KB memory page sizes for FHIR engine 1.2.0

2 participants