Upgrade to the new sqlcipher-android library#2938
Draft
Itskiprotich wants to merge 4 commits intogoogle:masterfrom
Draft
Upgrade to the new sqlcipher-android library#2938Itskiprotich wants to merge 4 commits intogoogle:masterfrom
Itskiprotich wants to merge 4 commits intogoogle:masterfrom
Conversation
jingtang10
requested changes
Jan 22, 2026
engine/src/main/java/com/google/android/fhir/db/impl/SQLCipherSupportHelper.kt
Show resolved
Hide resolved
Collaborator
|
Also - can you please make sure to test this e2e with an existing db? If people upgrade their app their existing db will still need to work. This is not a schema change so probably doesn't require a db "migration" but we need to make sure the library works. |
Contributor
Author
|
Sure, @jingtang10. I'm doing some rounds of test. I'll attached videos to the PR description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2892
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
output.mp4
checklist_reporting_compressed.mp4
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.