Flip ADK CLI to be ESM native instead of CommonJS#113
Merged
kalenkevich merged 1 commit intomainfrom Feb 5, 2026
Merged
Conversation
23ab555 to
43c2ad8
Compare
cornellgit
approved these changes
Feb 5, 2026
43c2ad8 to
d23753c
Compare
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces enhanced control over how agent files are loaded and compiled in the ADK CLI. It adds support for specifying whether to compile or bundle agent code and allows explicit definition of the module type (ESM/CJS). This helps in handling different project setups and ensures better compatibility, particularly with ESM projects.
Key Changes:
New CLI Flags:
npx adk run | web | api_server).Enhanced Agent Loading:
AgentFile class in dev/src/utils/agent_loader.ts updated to handle compilation and bundling options.
Added logic to automatically detect module type from file extensions (.mjs, .cjs) or package.json.
Added esbuild-shim-plugin to handle shims during bundling.
Enabled Debug with ADK CLI run command:
While working with ESM .js/.ts files you can run agent without file compile and bundle:
npx adk run ./agent.ts --compile=false --bundle=false. That allows to load and debug original files.Example of the VSCode launch.json config for debug:
Resolves:
#108
#76
#77