chore: upgrade openapi-generator-cli from v6.0.1 to v6.6.0 (Close please)#1365
Closed
chore: upgrade openapi-generator-cli from v6.0.1 to v6.6.0 (Close please)#1365
Conversation
Fixes rgxgen crash on date-time pattern `[0-9]{4}-[0-9]{2}-...`
that breaks SDK client generation after LocalDateTime schema
mapping was added in NAS.
tychtjan
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
Use python-prior generator to maintain compatibility with existing custom templates. The python generator was replaced with python-experimental in v6.2.0, which uses a different architecture (schemas.py instead of model_utils.py). Also updates API schemas with latest API changes. Relates to: STL-2347
tychtjan
force-pushed
the
jtyc/upgrade-openapi-generator-v6.6.0
branch
from
dca5f3b to
838e259
Compare
Relates to: STL-2347
tychtjan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/generate_client.shgeneratorNamefrompythontopython-priorto maintain compatibility with existing custom templates (thepythongenerator was replaced withpython-experimentalin v6.2.0)gooddata-api-clientpackage with the new generator versiongooddata-api-client.json,gooddata-automation-client.json,gooddata-export-client.json,gooddata-metadata-client.json)Context
Incremental upgrade within the v6.x line. A v7.x upgrade was evaluated but deferred — the
pythongenerator was replaced with a Pydantic-based architecture in v7, which would require rewriting all 6 custom templates and updating all downstream code.Related
jira: STL-2347
risk: high (prod)