feat: add WindowChrome interface for frameless window support#13
Merged
feat: add WindowChrome interface for frameless window support#13
Conversation
Add WindowChrome interface with HitTestResult enum (13 values), HitTestCallback type, and NullWindowChrome for testing. Enables custom window chrome with drag, resize, and button regions.
Add WindowChrome interface, HitTestResult enum, HitTestCallback, NullWindowChrome to CHANGELOG. Add WindowChrome to README features and usage section with frameless window example.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
WindowChromeinterface for custom window chrome (frameless windows) support.WindowChromeinterface:SetFrameless,IsFrameless,SetHitTestCallback,Minimize,Maximize,IsMaximized,CloseHitTestResultenum (13 values): Client, Caption, Close, Maximize, Minimize, 8 resize edges/cornersHitTestCallbacktype:func(x, y float64) HitTestResultNullWindowChrome: no-op implementation for testingdoc.go,README.md,CHANGELOG.mdEnables replacing OS window chrome with GPU-rendered custom title bars. The application provides hit-test regions via callback so the OS can handle dragging, resizing, and window button interactions.
Implemented by
gogpu.App(separate PR). Used byuiTitleBar widget.Test plan
TestNullWindowChrome_Defaults— nil-safetyTestNullWindowChrome_Actions— no panics on all methodsTestHitTestResult_String— all 13 valuesTestHitTestResult_Values— sequential constantsTestWindowChrome_CustomImplementation— frameless toggle, hit test callback, minimize, maximize toggle, closego test ./...passesgolangci-lint run— 0 issues