fix: use errors.As to detect TaskfileNotFoundError in getRootNode #2688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
taskshowsNo Taskfile found at ""instead of the full error message with path and--initsuggestionProblem
When running
taskin a directory without a Taskfile,NewFileNode()innode_file.gowrapsos.ErrNotExistinto aTaskfileNotFoundErrorbefore returning. IngetRootNode()(setup.go), theerror check uses
os.IsNotExist(err), which fails to match the already-wrapped error. As a result, the enriched error (with the correct path,Walk: true, andAskInit: true) is never constructed,and the incomplete
TaskfileNotFoundErrorfromNewFileNode()is returned as-is.Fix
Replace
os.IsNotExist(err)witherrors.As(err, &taskfileNotFoundErr)so that the wrappedTaskfileNotFoundErroris properly detected.Before:
task: No Taskfile found at ""After:
task: No Taskfile found at "/path/to/dir" (or any of the parent directories). Runtask --initto create a new Taskfile.Closes #2581