Improve error message when searching for Taskfile. #2682
+32
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trulede
force-pushed
the
PR/error-on-ownerchange
branch
from
1b52019 to
fbea9b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When searching for a Taskfile, and the directory ownership changes, provide a message indicating that.
In implementing this change, I noticed that the handling of TaskfileNotFoundError in setup.go would never be hit (bug) and also that the code in fs.go was a little odd - in so much that detecting this condition required returning valid paths and an err, which in many cases the caller would ignore anyway. But I think its OK, just a bit odd.
Fixes #1683