Skip to content

Increase test tolerances#24

Merged
ttl-octave merged 1 commit intognu-octave:mainfrom
svillemot:main
Feb 14, 2026
Merged

Increase test tolerances#24
ttl-octave merged 1 commit intognu-octave:mainfrom
svillemot:main

Conversation

@svillemot
Copy link
Member

@ttl-octave
Copy link
Member

Thanks for the patch. Maybe the accuracy of the steady state solution computed as "ground truth" is not sufficiently high. Would you mind to test increasing the loop count in the %! # asymptotic filter equations to 30 without increasing the tolerance?

@svillemot
Copy link
Member Author

Actually I realize that the problem is not linked to the ARM architecture.

The failure comes from the fact that the test is random. I could generate one failure on x86-64 using the following:

for i=1:100; test kalman; endfor

(in one of the runs, I got an error slightly above the tolerance of 2e-5, but smaller than the 3e-5 that I suggested in this PR).

I let you decide how you want to fix this. For the time being, the patch in this MR has been applied to the Debian package.

@ttl-octave ttl-octave merged commit a0c8ae8 into gnu-octave:main Feb 14, 2026
@ttl-octave
Copy link
Member

Good catch! I needed a loop over 1000 test to get a failed one. The input vector for the process noise is randomly chosen in one of the tests. I am merging the pull request and will increase the accuracy of the steady state computation afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments