Conversation
JustinGrote
commented
Mar 9, 2025
JustinGrote
commented
- Bump Octokit REST client to v21
- Enhance the Octokit client with retry and throttling capabilities to handle API rate limits more effectively.
- Address breaking change in variables API calls to use owner and repo parameters instead of repository_id.
There was a problem hiding this comment.
PR Overview
This pull request bumps the Octokit REST client to v21, enhances it with retry and throttling plugins, and updates API calls to use owner/repo parameters instead of repository_id.
- Update of client instantiation to incorporate throttling and retry plugins
- Refactoring API calls across multiple files to use owner and repo fields
- Minor configuration tweaks in eslint.config.mjs
Reviewed Changes
| File | Description |
|---|---|
| eslint.config.mjs | Added new ESLint configuration with ts-check and TypeScript ESLint integration |
| src/api/api.ts | Updated client creation to use Octokit plugins and adjusted types accordingly |
| src/git/repository.ts | Changed client type from Octokit to GhaOctokit in GitHub repository context |
| src/treeViews/settings/environmentVariablesNode.ts | Updated API call to replace repository_id with owner and repo parameters |
| src/treeViews/settings/environmentSecretsNode.ts | Similar update to use owner/repo in environment secrets API call |
| src/commands/variables/addVariable.ts | Updated API call to utilize owner and repo instead of repository_id |
| src/commands/secrets/deleteSecret.ts | Updated delete secret API call to use owner and repo parameters |
| src/commands/secrets/addSecret.ts | Updated secret creation API call with owner and repo parameters |
| src/api/handleSamlError.ts | Modified error handling to work with the new GhaOctokit type from the updated client |
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
|
@tntyordan you unsubscribe by managing your github notifications. What you just did was comment on the pull request, we cannot unsubscribe you. Thanks. |
|
@AnthonyBorton please review, thanks :) |
|
@JustinGrote - Thank you for the opportunity to approve your PR. As someone that is not a contributor to your project and has no familiarity with you or your project, I politely decline. |
Apologies, the autocomplete chose you instead of @AnthonyZavala for some reason. Ignore with my thanks. |
- Bump latest esbuild version explicity - Set CI Node to VSCode 1.98.0 Node Version - Fixup vscode tooling and enable format-on-save - Apply prettier configuration for whitespace remediation - Suppress new typescript warnings from newer TS version, to be fixed later
…es breaking change
JustinGrote
force-pushed
the
chore/octokit-rest-bump
branch
from
746a63d to
119ec4a
Compare
3 participants
