✨ Don't set default experiment for classes when includeing Scientist::Experiment#163
Open
danielvdao wants to merge 2 commits intogithub:mainfrom
Open
✨ Don't set default experiment for classes when includeing Scientist::Experiment#163danielvdao wants to merge 2 commits intogithub:mainfrom
includeing Scientist::Experiment#163danielvdao wants to merge 2 commits intogithub:mainfrom
Conversation
|
Would be nice to update the README to reflect/provide guidance on how to use this change 👍 |
shaizdragon87
approved these changes
Dec 16, 2021
Author
|
Hey @zerowidth is there any feedback / thoughts you have about this? There seems to be a lot of comments from folks on this issue. |
Member
|
@danielvdao I am not sure if what you are doing is the intent of the gem. I think that overriding the default class for the experiment is useful for publishing / etc, but there is no need to include For your example I would either include class SomeClass
include Scientist
def run_foo
foo = Foo.new
science "experiment" do |e|
e.try { foo.xxxxx }
e.use { foo.yyyyy }
end
end
endOr if that is not possible then run through class SomeClass
def run_foo
foo = Foo.new
Scientist.run "experiment" do |e|
e.try { foo.xxxxx }
e.use { foo.yyyyy }
end
end
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #162. I'm happy to close if it's unnecessary!
Thoughts:
I found that making a class the default experiment a little aggressive and wondered if there was another way around this. It looks like in the code I could do something like this, but this seems not ideal for two reasons:
Scientist::Experiment.set_default(Scientist::Default)to preserve backwards compatibility for current classes thatinclude Scientist, but notScientist::ExperimentScientist::Defaultwas not the default class, then this could be a breaking change for gem users)That said, I realized now that this might be my ignorance around the gem -- but it looks like running a scientist experiment class in isolation might not be "the right way to use the library" 😝 and I could've been wrong to begin with? Though I am wondering, if this allows for us to actually run multiple experiments at once 🤔 I attached a code snippet of what I was doing, and would love to hear thoughts!
I was doing something like the following:
then: