Remove old non-consolidated Actions and Projects toolsets#1958
Remove old non-consolidated Actions and Projects toolsets#1958
Conversation
This commit removes the old individual tool implementations for Actions and Projects toolsets that have been superseded by consolidated tools (actions_list, actions_get, actions_run_trigger, get_job_logs, projects_list, projects_get, projects_write). Removed old Actions tools: - ListWorkflows, ListWorkflowRuns, RunWorkflow, GetWorkflowRun - GetWorkflowRunLogs, ListWorkflowJobs, GetJobLogs - RerunWorkflowRun, RerunFailedJobs, CancelWorkflowRun - ListWorkflowRunArtifacts, DownloadWorkflowRunArtifact - DeleteWorkflowRunLogs, GetWorkflowRunUsage Removed old Projects tools: - ListProjects, GetProject, ListProjectFields, GetProjectField - ListProjectItems, GetProjectItem, AddProjectItem - UpdateProjectItem, DeleteProjectItem Also removed: - Feature flag constants (FeatureFlagHoldbackConsolidatedActions/Projects) - FeatureFlagDisable from consolidated tools - Old toolsnaps for removed tools - Tests for removed tools - Unused helper function toNewProjectType Co-authored-by: mattdholloway <918573+mattdholloway@users.noreply.github.com>
Co-authored-by: mattdholloway <918573+mattdholloway@users.noreply.github.com>
Co-authored-by: mattdholloway <918573+mattdholloway@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR removes legacy individual Actions and Projects tools that have been superseded by consolidated implementations. The removal deletes approximately 6,500 lines of code including 23 old tool functions, their associated tests, and 22 toolsnap files.
Changes:
- Removed 14 individual Actions tools and 9 individual Projects tools from
tools.go,actions.go, andprojects.go - Removed
FeatureFlagHoldbackConsolidatedActionsandFeatureFlagHoldbackConsolidatedProjectsfeature flag constants - Removed
FeatureFlagDisableassignments from consolidated tools (ActionsList,ActionsGet,ActionsRunTrigger,GetJobLogs,ProjectsList,ProjectsGet,ProjectsWrite) - Deleted all corresponding test cases and toolsnap files for removed tools
- Added
*.testto.gitignoreto exclude Go test binaries
Reviewed changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/tools.go | Removed 23 tool function calls from AllTools() registration |
| pkg/github/actions.go | Removed 14 old Actions tool functions (~1,400 lines) and feature flag constant; kept consolidated tools and helper functions |
| pkg/github/projects.go | Removed 9 old Projects tool functions (~1,000 lines), feature flag constant, and toNewProjectType helper; kept consolidated tools |
| pkg/github/actions_test.go | Removed all tests for old individual Actions tools (~1,800 lines) and unused imports; kept consolidated tool tests |
| pkg/github/projects_test.go | Removed all tests for old individual Projects tools (~1,500 lines); kept consolidated tool tests |
| pkg/github/toolsnaps/*.snap | Deleted 22 toolsnap files corresponding to removed tools |
| .gitignore | Added *.test pattern to exclude Go test binaries |
|
@copilot Undo your changes to .gitignore |
Co-authored-by: mattdholloway <918573+mattdholloway@users.noreply.github.com>
|
@copilot Ensure the new consolidated tools are set as default, do not make changes unless you absolutely need to |
The consolidated tools ( |
Summary
Removes legacy individual Actions and Projects tools that have been superseded by consolidated tools. ~6,500 lines of code deleted. The consolidated tools (
actions_list,actions_get,actions_run_trigger,get_job_logs,projects_list,projects_get,projects_write) are now the only and default implementations for their respective toolsets.Why
These tools were held back via feature flags during consolidation. The consolidated tools are now the canonical implementations with all feature flag restrictions removed.
What changed
ListWorkflows,ListWorkflowRuns,RunWorkflow,GetWorkflowRun,GetWorkflowRunLogs,ListWorkflowJobs,GetJobLogs,RerunWorkflowRun,RerunFailedJobs,CancelWorkflowRun,ListWorkflowRunArtifacts,DownloadWorkflowRunArtifact,DeleteWorkflowRunLogs,GetWorkflowRunUsageListProjects,GetProject,ListProjectFields,GetProjectField,ListProjectItems,GetProjectItem,AddProjectItem,UpdateProjectItem,DeleteProjectItemFeatureFlagHoldbackConsolidatedActionsandFeatureFlagHoldbackConsolidatedProjectsconstantsFeatureFlagDisablefrom consolidated tools, making them always enabled when their toolset is usedMCP impact
deprecated_tool_aliases.goredirectsPrompts tested (tool changes only)
Security / limits
Tool renaming
Note: Existing aliases in
deprecated_tool_aliases.goare preserved for backward compatibility.Lint & tests
./script/lint./script/testDocs
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.