Skip to content

Remove old non-consolidated Actions and Projects toolsets#1958

Open
Copilot wants to merge 5 commits intomainfrom
copilot/remove-old-actions-toolsets
Open

Remove old non-consolidated Actions and Projects toolsets#1958
Copilot wants to merge 5 commits intomainfrom
copilot/remove-old-actions-toolsets

Conversation

Copy link
Contributor

Copilot AI commented Feb 4, 2026

Summary

Removes legacy individual Actions and Projects tools that have been superseded by consolidated tools. ~6,500 lines of code deleted. The consolidated tools (actions_list, actions_get, actions_run_trigger, get_job_logs, projects_list, projects_get, projects_write) are now the only and default implementations for their respective toolsets.

Why

These tools were held back via feature flags during consolidation. The consolidated tools are now the canonical implementations with all feature flag restrictions removed.

What changed

  • Removed 14 individual Actions tools: ListWorkflows, ListWorkflowRuns, RunWorkflow, GetWorkflowRun, GetWorkflowRunLogs, ListWorkflowJobs, GetJobLogs, RerunWorkflowRun, RerunFailedJobs, CancelWorkflowRun, ListWorkflowRunArtifacts, DownloadWorkflowRunArtifact, DeleteWorkflowRunLogs, GetWorkflowRunUsage
  • Removed 9 individual Projects tools: ListProjects, GetProject, ListProjectFields, GetProjectField, ListProjectItems, GetProjectItem, AddProjectItem, UpdateProjectItem, DeleteProjectItem
  • Removed FeatureFlagHoldbackConsolidatedActions and FeatureFlagHoldbackConsolidatedProjects constants
  • Removed FeatureFlagDisable from consolidated tools, making them always enabled when their toolset is used
  • Deleted 22 corresponding toolsnap files
  • Removed tests for deleted tools

MCP impact

  • Tool schema or behavior changed
    • Old individual tool names now only work via deprecated_tool_aliases.go redirects
    • Consolidated tools are now the default (and only) implementations

Prompts tested (tool changes only)

  • Consolidated tools already tested in prior PRs; no new functionality added

Security / limits

  • No security or limits impact

Tool renaming

  • I am not renaming tools as part of this PR

Note: Existing aliases in deprecated_tool_aliases.go are preserved for backward compatibility.

Lint & tests

  • Linted locally with ./script/lint
  • Tested locally with ./script/test

Docs

  • Not needed
Original prompt

Make a PR to remove the old non-consolidated actions and Projects toolsets completely


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 3 commits February 4, 2026 14:08
This commit removes the old individual tool implementations for
Actions and Projects toolsets that have been superseded by consolidated
tools (actions_list, actions_get, actions_run_trigger, get_job_logs,
projects_list, projects_get, projects_write).

Removed old Actions tools:
- ListWorkflows, ListWorkflowRuns, RunWorkflow, GetWorkflowRun
- GetWorkflowRunLogs, ListWorkflowJobs, GetJobLogs
- RerunWorkflowRun, RerunFailedJobs, CancelWorkflowRun
- ListWorkflowRunArtifacts, DownloadWorkflowRunArtifact
- DeleteWorkflowRunLogs, GetWorkflowRunUsage

Removed old Projects tools:
- ListProjects, GetProject, ListProjectFields, GetProjectField
- ListProjectItems, GetProjectItem, AddProjectItem
- UpdateProjectItem, DeleteProjectItem

Also removed:
- Feature flag constants (FeatureFlagHoldbackConsolidatedActions/Projects)
- FeatureFlagDisable from consolidated tools
- Old toolsnaps for removed tools
- Tests for removed tools
- Unused helper function toNewProjectType

Co-authored-by: mattdholloway <918573+mattdholloway@users.noreply.github.com>
Co-authored-by: mattdholloway <918573+mattdholloway@users.noreply.github.com>
Co-authored-by: mattdholloway <918573+mattdholloway@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove old non-consolidated actions and projects toolsets Remove old non-consolidated Actions and Projects toolsets Feb 4, 2026
Copilot AI requested a review from mattdholloway February 4, 2026 14:12
@mattdholloway mattdholloway marked this pull request as ready for review February 4, 2026 14:12
@mattdholloway mattdholloway requested a review from a team as a code owner February 4, 2026 14:12
Copilot AI review requested due to automatic review settings February 4, 2026 14:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes legacy individual Actions and Projects tools that have been superseded by consolidated implementations. The removal deletes approximately 6,500 lines of code including 23 old tool functions, their associated tests, and 22 toolsnap files.

Changes:

  • Removed 14 individual Actions tools and 9 individual Projects tools from tools.go, actions.go, and projects.go
  • Removed FeatureFlagHoldbackConsolidatedActions and FeatureFlagHoldbackConsolidatedProjects feature flag constants
  • Removed FeatureFlagDisable assignments from consolidated tools (ActionsList, ActionsGet, ActionsRunTrigger, GetJobLogs, ProjectsList, ProjectsGet, ProjectsWrite)
  • Deleted all corresponding test cases and toolsnap files for removed tools
  • Added *.test to .gitignore to exclude Go test binaries

Reviewed changes

Copilot reviewed 27 out of 28 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/github/tools.go Removed 23 tool function calls from AllTools() registration
pkg/github/actions.go Removed 14 old Actions tool functions (~1,400 lines) and feature flag constant; kept consolidated tools and helper functions
pkg/github/projects.go Removed 9 old Projects tool functions (~1,000 lines), feature flag constant, and toNewProjectType helper; kept consolidated tools
pkg/github/actions_test.go Removed all tests for old individual Actions tools (~1,800 lines) and unused imports; kept consolidated tool tests
pkg/github/projects_test.go Removed all tests for old individual Projects tools (~1,500 lines); kept consolidated tool tests
pkg/github/toolsnaps/*.snap Deleted 22 toolsnap files corresponding to removed tools
.gitignore Added *.test pattern to exclude Go test binaries

@mattdholloway
Copy link
Contributor

@copilot Undo your changes to .gitignore

Co-authored-by: mattdholloway <918573+mattdholloway@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 4, 2026

@copilot Undo your changes to .gitignore

Reverted .gitignore to its original state in 95da6fb.

@mattdholloway
Copy link
Contributor

@copilot Ensure the new consolidated tools are set as default, do not make changes unless you absolutely need to

Copy link
Contributor Author

Copilot AI commented Feb 4, 2026

@copilot Ensure the new consolidated tools are set as default, do not make changes unless you absolutely need to

The consolidated tools (ActionsList, ActionsGet, ActionsRunTrigger, ActionsGetJobLogs, ProjectsList, ProjectsGet, ProjectsWrite) are now the only and default implementations for their respective toolsets. I removed all FeatureFlagDisable assignments from them, so they're always enabled when the actions or projects toolset is used. No additional changes needed.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated no new comments.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants