Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds configurable token format validation to the authentication middleware. When enabled, the middleware returns 401 Unauthorized with WWW-Authenticate headers for invalid token formats; when disabled (default), it returns 400 Bad Request, allowing downstream systems (like CAPI) to handle validation.
Changes:
- Added
ValidateTokenFormatboolean field to OAuth config to control error response behavior - Updated token extraction middleware to conditionally return 401 vs 400 for invalid tokens
- Added comprehensive unit tests covering all token validation scenarios
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/http/oauth/oauth.go | Adds ValidateTokenFormat configuration field with clear documentation |
| pkg/http/middleware/token.go | Updates error handling logic to check ValidateTokenFormat and return appropriate status code |
| pkg/http/middleware/token_test.go | Adds comprehensive table-driven tests for token extraction middleware and helper functions |
a5d7bde to
a41d683
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request updates the token extraction middleware to support configurable handling of invalid token formats, and introduces comprehensive unit tests for its behavior. The main change is the addition of a
ValidateTokenFormatoption in the OAuth config, which determines whether the middleware returns a 401 Unauthorized (with a WWW-Authenticate header) or a 400 Bad Request for invalid token formats. This makes the authentication flow more flexible and testable.Why
Fixes #
What changed
MCP impact
Prompts tested (tool changes only)
Security / limits
Tool renaming
deprecated_tool_aliases.goNote: if you're renaming tools, you must add the tool aliases. For more information on how to do so, please refer to the official docs.
Lint & tests
./script/lint./script/testDocs