Fix dark mode styling on first load if dark mode is system preference#2128
Merged
dscho merged 1 commit intogit:gh-pagesfrom Jan 30, 2026
Merged
Fix dark mode styling on first load if dark mode is system preference#2128dscho merged 1 commit intogit:gh-pagesfrom
dscho merged 1 commit intogit:gh-pagesfrom
Conversation
Previously, these three elements only checked for data-theme="dark", which is not set if the page is first loaded and dark mode is the system default.
dscho
approved these changes
Jan 30, 2026
Member
dscho
left a comment
dscho
left a comment
There was a problem hiding this comment.
Great catch, and thank you for fixing it! https://github.com/search?q=repo%3Agit%2Fgit-scm.com%20%3Aroot%5Bdata-theme%3D%22dark%22%5D&type=code confirms that this patch covers all of the affected instances.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Context
Previously, these three elements only checked for data-theme="dark", which is not set if the page is first loaded and dark mode is the system default.
Before
After