fixed: ordering of videos has been fixed at: /videos to show episodes in correct order#2084
fixed: ordering of videos has been fixed at: /videos to show episodes in correct order#2084Paulie-Aditya wants to merge 5 commits intogit:gh-pagesfrom
Conversation
… 1 and 3 on the left column, and 2 and 4 on the right column
|
@To1ne Kindly let me know if the commit message is now appropriately defined, if not kindly guide me in the right direction for the same as well, would be more than happy to understand and contribute more meaningfully! Cheers! |
|
@Paulie-Aditya Let me suggest something like: Some notes from this:
But I've noticed something else. On mobile (small screens) the order is still wrong. We should switch to CSS grid or flexbox to make sure the order is persisted across viewports. |
|
Okay, will do the changes as instructed, thanks for the guidance! |
|
I find it very nice to see progress here! Unfortunately, these changes are way over my head, so I cannot contribute to the review 😞 |
To1ne
left a comment
There was a problem hiding this comment.
@Paulie-Aditya Awesome. I've added a few suggestions, but this is just what I wanted.
| } | ||
|
|
||
| img { | ||
| width: 100%; |
There was a problem hiding this comment.
We better also add box-sizing: border-box due to this.
|
|
||
| h4 { | ||
| margin: 0.75rem 0; | ||
| } |
|
sorry been pre-occupied, will definitely implement these soon. |
No worries, we all got stuff to do. 💜 |

Changes
Simply flipped over the conditions and that fixed it
in the left column: episodes 1 and 3
in the right column: episodes 2 and 4
Context
@To1ne brought this issue up once, that the video ordering on : https://git-scm.com/videos is wrong.
Specifically, episodes 2 and 4 are in the left column and the episodes 1 and 3 are in the right column.