Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
bitsandfoxes
force-pushed
the
chore/cleanup-jni-bridge
branch
from
3aea70b to
c9537e9
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| if ($_.Exception.Message -match "Activity class .* does not exist" -or $_.Exception.Message -match "Error type 3") { | ||
| Write-Host "Activity not found, trying fallback: $($script:FallbackAndroidComponent)" | ||
| $script:AndroidComponent = $script:FallbackAndroidComponent | ||
| $runResult = Invoke-DeviceApp -ExecutablePath $script:AndroidComponent -Arguments $extras |
There was a problem hiding this comment.
Fallback variable FallbackAndroidComponent is never defined
High Severity
The newly added fallback logic references $script:FallbackAndroidComponent, but this variable is never defined anywhere in the file or the codebase. The script sets $script:AndroidComponent in the BeforeAll block (choosing between UnityPlayerGameActivity and UnityPlayerActivity), but there's no corresponding assignment for the fallback. Since the script runs with Set-StrictMode -Version latest, accessing this undefined variable will throw a terminating error, causing the fallback path to always fail instead of recovering gracefully.
1 participant
Follows #2548 that surfaced some improvements regarding cleanup and better logging.
#skip-changelog