Cirrus Labs runners for all the other workflows + Ubuntu update (22.04 -> 24.04)#5696
Cirrus Labs runners for all the other workflows + Ubuntu update (22.04 -> 24.04)#5696
Conversation
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 59d1977+dirty | 416.06 ms | 434.46 ms | 18.40 ms |
| c1573b3 | 400.85 ms | 411.82 ms | 10.97 ms |
| b1579bc+dirty | 486.47 ms | 527.14 ms | 40.67 ms |
| 4052277+dirty | 421.88 ms | 446.98 ms | 25.10 ms |
| c7f264b | 434.98 ms | 452.96 ms | 17.98 ms |
| 6479fd5+dirty | 412.95 ms | 434.02 ms | 21.07 ms |
| 4a17c8f+dirty | 406.62 ms | 400.58 ms | -6.04 ms |
| cdf7e97+dirty | 459.49 ms | 495.10 ms | 35.61 ms |
| 000da7a | 454.46 ms | 445.00 ms | -9.46 ms |
| a06e222+dirty | 434.00 ms | 439.35 ms | 5.35 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 59d1977+dirty | 43.75 MiB | 48.40 MiB | 4.64 MiB |
| c1573b3 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| b1579bc+dirty | 43.75 MiB | 48.41 MiB | 4.66 MiB |
| 4052277+dirty | 43.75 MiB | 48.55 MiB | 4.80 MiB |
| c7f264b | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 6479fd5+dirty | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 4a17c8f+dirty | 43.75 MiB | 47.99 MiB | 4.24 MiB |
| cdf7e97+dirty | 43.75 MiB | 48.40 MiB | 4.64 MiB |
| 000da7a | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| a06e222+dirty | 43.75 MiB | 48.55 MiB | 4.80 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 90e7cb3+dirty | 1206.61 ms | 1209.46 ms | 2.84 ms |
| 60cd796+dirty | 1204.87 ms | 1202.71 ms | -2.17 ms |
| 8e653ac+dirty | 1218.63 ms | 1223.88 ms | 5.24 ms |
| f70acbf+dirty | 1235.71 ms | 1243.14 ms | 7.43 ms |
| ad27f6e+dirty | 1223.41 ms | 1246.29 ms | 22.88 ms |
| 6c11c6a+dirty | 1202.43 ms | 1212.70 ms | 10.27 ms |
| 664c66f+dirty | 1215.37 ms | 1221.30 ms | 5.92 ms |
| d916aa3+dirty | 1221.02 ms | 1228.98 ms | 7.96 ms |
| 36841a6+dirty | 1221.32 ms | 1222.17 ms | 0.85 ms |
| bca62c0+dirty | 1183.61 ms | 1183.76 ms | 0.14 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 90e7cb3+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 60cd796+dirty | 3.44 MiB | 4.67 MiB | 1.23 MiB |
| 8e653ac+dirty | 2.63 MiB | 4.01 MiB | 1.38 MiB |
| f70acbf+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
| ad27f6e+dirty | 3.41 MiB | 4.67 MiB | 1.25 MiB |
| 6c11c6a+dirty | 3.44 MiB | 4.60 MiB | 1.16 MiB |
| 664c66f+dirty | 3.38 MiB | 4.60 MiB | 1.22 MiB |
| d916aa3+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 36841a6+dirty | 3.41 MiB | 4.67 MiB | 1.25 MiB |
| bca62c0+dirty | 3.38 MiB | 4.60 MiB | 1.22 MiB |
| jobs: | ||
| add_label: | ||
| runs-on: ubuntu-latest | ||
| runs-on: ["ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04", "runner_group_id:12"] |
There was a problem hiding this comment.
Is it possible to centralize runs-on: ["ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04", "runner_group_id:12"] on a single job so others can share it?
That would make it easier in case we need to update it, avoiding updating the same reference on all jobs. It might be possible with reusable workflows.
There was a problem hiding this comment.
unfortunately, GH doesn't support using env context in runs-on directly, neither it supports using any sort of constants to specify something that's gonna be shared between all the workflows. so we have to stick to manual specification for now
|
The PR is looking good! I left a few topics in regard to the number 12 and also the possibility on reusing. |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 90e7cb3+dirty | 1212.61 ms | 1213.80 ms | 1.19 ms |
| 60cd796+dirty | 1206.08 ms | 1213.36 ms | 7.28 ms |
| 8e653ac+dirty | 1215.46 ms | 1220.20 ms | 4.75 ms |
| f70acbf+dirty | 1239.00 ms | 1242.53 ms | 3.53 ms |
| ad27f6e+dirty | 1214.28 ms | 1203.67 ms | -10.62 ms |
| 6c11c6a+dirty | 1217.55 ms | 1221.49 ms | 3.94 ms |
| 664c66f+dirty | 1195.94 ms | 1194.80 ms | -1.14 ms |
| d916aa3+dirty | 1211.02 ms | 1221.33 ms | 10.31 ms |
| 36841a6+dirty | 1215.87 ms | 1217.27 ms | 1.40 ms |
| bca62c0+dirty | 1219.65 ms | 1226.14 ms | 6.50 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 90e7cb3+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 60cd796+dirty | 3.44 MiB | 4.67 MiB | 1.23 MiB |
| 8e653ac+dirty | 3.19 MiB | 4.58 MiB | 1.39 MiB |
| f70acbf+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
| ad27f6e+dirty | 3.41 MiB | 4.67 MiB | 1.25 MiB |
| 6c11c6a+dirty | 3.44 MiB | 4.60 MiB | 1.16 MiB |
| 664c66f+dirty | 3.38 MiB | 4.60 MiB | 1.22 MiB |
| d916aa3+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 36841a6+dirty | 3.41 MiB | 4.67 MiB | 1.25 MiB |
| bca62c0+dirty | 3.38 MiB | 4.60 MiB | 1.22 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 11ded16+dirty | 309.23 ms | 310.55 ms | 1.33 ms |
| c08359e+dirty | 406.04 ms | 428.87 ms | 22.83 ms |
| 6bb8427+dirty | 393.25 ms | 414.96 ms | 21.71 ms |
| 23080e5+dirty | 347.29 ms | 381.87 ms | 34.58 ms |
| d751a5d+dirty | 341.61 ms | 403.06 ms | 61.45 ms |
| b3b5b0d+dirty | 361.42 ms | 403.90 ms | 42.48 ms |
| a3f3291+dirty | 399.06 ms | 432.43 ms | 33.36 ms |
| 4052277+dirty | 369.90 ms | 381.16 ms | 11.26 ms |
| 59d1977+dirty | 366.15 ms | 393.21 ms | 27.06 ms |
| d9f44bb+dirty | 460.61 ms | 496.62 ms | 36.00 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 11ded16+dirty | 7.15 MiB | 8.46 MiB | 1.31 MiB |
| c08359e+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 6bb8427+dirty | 43.94 MiB | 48.91 MiB | 4.97 MiB |
| 23080e5+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| d751a5d+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| b3b5b0d+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| a3f3291+dirty | 43.94 MiB | 48.90 MiB | 4.96 MiB |
| 4052277+dirty | 43.94 MiB | 49.38 MiB | 5.44 MiB |
| 59d1977+dirty | 43.94 MiB | 49.22 MiB | 5.29 MiB |
| d9f44bb+dirty | 43.94 MiB | 49.22 MiB | 5.29 MiB |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| branches: | ||
| - main | ||
| - alwx/ci/macos-tahoe-cl-runners | ||
| - alwx/experiment/cirrus-labs-for-everythin |
There was a problem hiding this comment.
Experimental branch left in testflight trigger
Medium Severity
The branch alwx/experiment/cirrus-labs-for-everythin was added as a push trigger for the Testflight upload workflow. This appears to be a temporary developer branch used for testing CI changes and was likely not intended to remain in the final PR. The old experimental branch alwx/ci/macos-tahoe-cl-runners was supposed to be removed (as noted in the PR discussion), but instead it was replaced with another experimental branch. This will trigger Testflight uploads on pushes to that branch, consuming CI resources unnecessarily.
There was a problem hiding this comment.
gonna be removed before merge!
itaybre
left a comment
There was a problem hiding this comment.
I don't think everything should run on Cirrus, specially if stability / speed is not important.
For example, danger, codeql, benchmarking, dependencies don't seem to benefit from running on cirrus runners.
Runners are a limited resource, all the organization shares


📢 Type of change
📜 Description
Hopefully that last bit of Cirrus Labs runners project — this time it's about moving to Ubuntu runners and replacing the old Sequoia to Tahoe where it's possible.
💡 Motivation and Context
Speed!
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps