Conversation
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
| release: env.EAS_BUILD_APP_VERSION, | ||
| tags: { ...createEASBuildTags(env), ...customTags }, | ||
| contexts: { eas_build: createEASBuildContext(env), runtime: { name: 'node', version: process.version } }, | ||
| sdk: { name: 'sentry.javascript.react-native.eas-build-hooks', version: '1.0.0' }, |
There was a problem hiding this comment.
Hardcoded SDK version diverges from actual package version
Medium Severity
The sdk.version in createBaseEvent is hardcoded as '1.0.0' while the actual package version is '8.1.0'. The SDK_VERSION constant is already available in ../version and used elsewhere (e.g., sdkinfo.ts). This means every EAS build hook event sent to Sentry will report an incorrect SDK version, and it will never auto-update with future releases.
There was a problem hiding this comment.
This feedback looks valid 👍
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eeebd10+dirty | 493.12 ms | 545.91 ms | 52.79 ms |
| 664c66f+dirty | 434.82 ms | 471.38 ms | 36.56 ms |
| d73150f+dirty | 411.21 ms | 465.86 ms | 54.65 ms |
| 4a17c8f+dirty | 406.62 ms | 400.58 ms | -6.04 ms |
| 2adbd1e+dirty | 433.98 ms | 427.96 ms | -6.02 ms |
| 98f632c | 424.25 ms | 435.48 ms | 11.23 ms |
| 9ced351+dirty | 405.40 ms | 419.39 ms | 13.98 ms |
| 64cd15c | 439.02 ms | 427.63 ms | -11.39 ms |
| 8490686+dirty | 365.59 ms | 400.24 ms | 34.65 ms |
| 1853710 | 555.47 ms | 556.59 ms | 1.12 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eeebd10+dirty | 43.75 MiB | 48.41 MiB | 4.66 MiB |
| 664c66f+dirty | 43.75 MiB | 48.55 MiB | 4.80 MiB |
| d73150f+dirty | 43.75 MiB | 48.55 MiB | 4.80 MiB |
| 4a17c8f+dirty | 43.75 MiB | 47.99 MiB | 4.24 MiB |
| 2adbd1e+dirty | 17.75 MiB | 19.70 MiB | 1.96 MiB |
| 98f632c | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 9ced351+dirty | 43.75 MiB | 48.41 MiB | 4.66 MiB |
| 64cd15c | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 8490686+dirty | 17.75 MiB | 19.70 MiB | 1.96 MiB |
| 1853710 | 17.75 MiB | 19.68 MiB | 1.94 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 90e7cb3+dirty | 1206.61 ms | 1209.46 ms | 2.84 ms |
| 60cd796+dirty | 1204.87 ms | 1202.71 ms | -2.17 ms |
| 8e653ac+dirty | 1218.63 ms | 1223.88 ms | 5.24 ms |
| f70acbf+dirty | 1235.71 ms | 1243.14 ms | 7.43 ms |
| ad27f6e+dirty | 1223.41 ms | 1246.29 ms | 22.88 ms |
| 6c11c6a+dirty | 1202.43 ms | 1212.70 ms | 10.27 ms |
| 664c66f+dirty | 1215.37 ms | 1221.30 ms | 5.92 ms |
| d916aa3+dirty | 1221.02 ms | 1228.98 ms | 7.96 ms |
| 36841a6+dirty | 1221.32 ms | 1222.17 ms | 0.85 ms |
| bca62c0+dirty | 1183.61 ms | 1183.76 ms | 0.14 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 90e7cb3+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 60cd796+dirty | 3.44 MiB | 4.67 MiB | 1.23 MiB |
| 8e653ac+dirty | 2.63 MiB | 4.01 MiB | 1.38 MiB |
| f70acbf+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
| ad27f6e+dirty | 3.41 MiB | 4.67 MiB | 1.25 MiB |
| 6c11c6a+dirty | 3.44 MiB | 4.60 MiB | 1.16 MiB |
| 664c66f+dirty | 3.38 MiB | 4.60 MiB | 1.22 MiB |
| d916aa3+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 36841a6+dirty | 3.41 MiB | 4.67 MiB | 1.25 MiB |
| bca62c0+dirty | 3.38 MiB | 4.60 MiB | 1.22 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 664c66f+dirty | 376.23 ms | 389.51 ms | 13.28 ms |
| d73150f+dirty | 424.60 ms | 454.35 ms | 29.75 ms |
| 4a17c8f+dirty | 368.54 ms | 381.43 ms | 12.89 ms |
| b3b5b0d+dirty | 361.42 ms | 403.90 ms | 42.48 ms |
| 9ced351+dirty | 361.74 ms | 411.45 ms | 49.70 ms |
| 7886639+dirty | 530.30 ms | 571.34 ms | 41.04 ms |
| c08359e+dirty | 406.04 ms | 428.87 ms | 22.83 ms |
| 3099014+dirty | 344.58 ms | 404.21 ms | 59.63 ms |
| d751a5d+dirty | 341.61 ms | 403.06 ms | 61.45 ms |
| 682f0f5+dirty | 402.33 ms | 440.61 ms | 38.28 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 664c66f+dirty | 43.94 MiB | 49.38 MiB | 5.44 MiB |
| d73150f+dirty | 43.94 MiB | 49.38 MiB | 5.44 MiB |
| 4a17c8f+dirty | 43.94 MiB | 48.82 MiB | 4.88 MiB |
| b3b5b0d+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 9ced351+dirty | 43.94 MiB | 49.27 MiB | 5.33 MiB |
| 7886639+dirty | 43.94 MiB | 49.28 MiB | 5.34 MiB |
| c08359e+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 3099014+dirty | 7.15 MiB | 8.43 MiB | 1.27 MiB |
| d751a5d+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 682f0f5+dirty | 43.94 MiB | 48.91 MiB | 4.97 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 90e7cb3+dirty | 1212.61 ms | 1213.80 ms | 1.19 ms |
| 60cd796+dirty | 1206.08 ms | 1213.36 ms | 7.28 ms |
| 8e653ac+dirty | 1215.46 ms | 1220.20 ms | 4.75 ms |
| f70acbf+dirty | 1239.00 ms | 1242.53 ms | 3.53 ms |
| ad27f6e+dirty | 1214.28 ms | 1203.67 ms | -10.62 ms |
| 6c11c6a+dirty | 1217.55 ms | 1221.49 ms | 3.94 ms |
| 664c66f+dirty | 1195.94 ms | 1194.80 ms | -1.14 ms |
| d916aa3+dirty | 1211.02 ms | 1221.33 ms | 10.31 ms |
| 36841a6+dirty | 1215.87 ms | 1217.27 ms | 1.40 ms |
| bca62c0+dirty | 1219.65 ms | 1226.14 ms | 6.50 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 90e7cb3+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 60cd796+dirty | 3.44 MiB | 4.67 MiB | 1.23 MiB |
| 8e653ac+dirty | 3.19 MiB | 4.58 MiB | 1.39 MiB |
| f70acbf+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
| ad27f6e+dirty | 3.41 MiB | 4.67 MiB | 1.25 MiB |
| 6c11c6a+dirty | 3.44 MiB | 4.60 MiB | 1.16 MiB |
| 664c66f+dirty | 3.38 MiB | 4.60 MiB | 1.22 MiB |
| d916aa3+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 36841a6+dirty | 3.41 MiB | 4.67 MiB | 1.25 MiB |
| bca62c0+dirty | 3.38 MiB | 4.60 MiB | 1.22 MiB |
Yeah, adding a feature changelog would be nice. |
| * | ||
| * Add it to your package.json scripts: | ||
| * | ||
| * "eas-build-on-complete": "sentry-eas-build-on-complete" |
There was a problem hiding this comment.
It would be nice to have docs for these features and add a small mention on how to use them on changelog.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| return Array.from(bytes) | ||
| .map(b => b.toString(16).padStart(2, '0')) | ||
| .join(''); | ||
| } |
There was a problem hiding this comment.
Custom UUID generation duplicates existing uuid4 utility
Low Severity
The generateEventId function reimplements UUID v4 generation in ~19 lines, but uuid4 from @sentry/core already provides the same functionality and is used elsewhere in the codebase (e.g., in profiling/integration.ts and tracing/utils.ts). Since this module already imports makeDsn and dsnToString from @sentry/core, there's no reason to avoid also importing uuid4. This duplication adds unnecessary maintenance burden.


📢 Type of change
📜 Description
Introduces build hooks for EAS and fixes #5428
📝 Checklist
sendDefaultPIIis enabled