Skip to content

feat: Made ManifestMetaDataReader read the DIST#5107

Open
bitsandfoxes wants to merge 1 commit intomainfrom
feat/manifest-read-dist
Open

feat: Made ManifestMetaDataReader read the DIST#5107
bitsandfoxes wants to merge 1 commit intomainfrom
feat/manifest-read-dist

Conversation

@bitsandfoxes
Copy link
Contributor

📜 Description

The ManifestMetaDataReader reads a lot of things, but not DIST. But the DIST can be provided through the options. Now if the Sentry SDK for Unity would want to share its DIST with the Android layer, it cannot do so if it sets up auto-initialization.

💡 Motivation and Context

Why is this change required?
Because the ManifestMetaDataReader did not read DIST - until now.

What problem does it solve?
It solves the problem of the ManifestMetaDataReader not reading the DIST.

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Release!

@bitsandfoxes bitsandfoxes changed the title feat: ManifestMetaDataReader reads DIST feat: Made ManifestMetaDataReader read the DIST Feb 20, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2026

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • Made ManifestMetaDataReader read the DIST by bitsandfoxes in #5107

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Features

- Made `ManifestMetaDataReader` read the `DIST` ([#5107](https://github.com/getsentry/sentry-java/pull/5107))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against 1d140a0

@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 323.11 ms 404.30 ms 81.19 ms
Size 1.58 MiB 2.29 MiB 719.77 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
cf708bd 434.73 ms 502.96 ms 68.22 ms
d15471f 310.66 ms 368.19 ms 57.53 ms
d217708 355.34 ms 381.39 ms 26.05 ms
d364ace 411.72 ms 430.81 ms 19.10 ms
dcc6bbf 382.58 ms 462.13 ms 79.54 ms
fc5ccaf 279.11 ms 353.34 ms 74.23 ms
f064536 349.86 ms 417.66 ms 67.80 ms
dba088c 333.98 ms 381.16 ms 47.18 ms
cf708bd 408.35 ms 458.98 ms 50.63 ms
ee747ae 357.79 ms 421.84 ms 64.05 ms

App size

Revision Plain With Sentry Diff
cf708bd 1.58 MiB 2.11 MiB 539.71 KiB
d15471f 1.58 MiB 2.13 MiB 559.54 KiB
d217708 1.58 MiB 2.10 MiB 532.97 KiB
d364ace 1.58 MiB 2.11 MiB 539.75 KiB
dcc6bbf 1.58 MiB 2.12 MiB 553.10 KiB
fc5ccaf 1.58 MiB 2.13 MiB 557.54 KiB
f064536 1.58 MiB 2.20 MiB 633.90 KiB
dba088c 1.58 MiB 2.13 MiB 558.99 KiB
cf708bd 1.58 MiB 2.11 MiB 539.71 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments