-
-
Notifications
You must be signed in to change notification settings - Fork 466
feat(screenshot): Add screenshot masking using view hierarchy #5077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
romtsn
wants to merge
20
commits into
main
Choose a base branch
from
rz/feat/screenshot-masking
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
469086f
feat(screenshot): Add screenshot masking using view hierarchy
romtsn 17beece
Changelog
romtsn 49f4517
dontwarn about classes we check via reflection at runtime
romtsn ad8d6df
pr id
romtsn 5242ed6
fix(screenshot): Only warn about missing replay module when masking i…
romtsn 115107b
fix(screenshot): Remove sensitive view classes when setMaskAllImages(…
romtsn 83da7df
fix(screenshot): Recycle bitmap copy on masking failure to prevent me…
romtsn b26b448
Merge remote-tracking branch 'origin/main' into rz/feat/screenshot-ma…
romtsn 2b8e4aa
fix: Resolve merge conflicts with main and integrate trackCustomMasking
romtsn 69e5d56
Clean up slop
romtsn 55819a4
fix(test): Implement abstract trackCustomMasking in test stub
romtsn 5084ed2
fix(screenshot): Use peekDecorView instead of getDecorView
romtsn b37b2eb
refactor(screenshot): Per-call MaskRenderer, main-thread VH capture, …
romtsn 2ea0893
Fix tests and remove slop
romtsn 700f5d7
clean up
romtsn fd452e9
fix(masking): Remove from opposite set when adding mask/unmask view c…
romtsn 6f1933c
delegate to super in SentryReplayOptions
romtsn 2e8662b
Do not capture screenshot when copy bitmap fails
romtsn b85eb89
fix(screenshot): Recycle bitmaps on all early-return paths to prevent…
romtsn b85f24e
fix(screenshot): Log missing replay module warning once in constructo…
romtsn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.