fix(taskfile): aws auth check incorrectly returns non-zero#162
Merged
rochecompaan merged 1 commit intomainfrom Mar 3, 2026
Merged
fix(taskfile): aws auth check incorrectly returns non-zero#162rochecompaan merged 1 commit intomainfrom
rochecompaan merged 1 commit intomainfrom
Conversation
licquia
approved these changes
Mar 3, 2026
getscaf-release-bot bot
pushed a commit
that referenced
this pull request
Mar 3, 2026
## [1.13.1](v1.13.0...v1.13.1) (2026-03-03) ### Bug Fixes * **taskfile:** aws auth check incorrectly returns non-zero ([#162](#162)) ([a174dc4](a174dc4))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
In Taskfile.yml, replaced:
with:
Why
[ ... ] is a command (test) and returns:
In the old A && B form, a false comparison returns 1, so the whole line returns non-zero.
Because go-task runs commands in fail-fast mode, that non-zero status caused establish-aws-login to abort, even on normal “not
expired yet” paths.
Result
The expiration check now uses explicit control flow (if), so a false condition is treated as expected logic, not a task failure.
This prevents spurious non-zero exits both locally and in GitHub Actions.