fix: increase test timeout and remove unnecessary hook debugging#706
Open
jakelorocco wants to merge 2 commits intomainfrom
Open
fix: increase test timeout and remove unnecessary hook debugging#706jakelorocco wants to merge 2 commits intomainfrom
jakelorocco wants to merge 2 commits intomainfrom
Conversation
Contributor
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
jakelorocco
force-pushed
the
jal/minor-github-test-fixes
branch
from
642b2c8 to
de70aed
Compare
psschwei
approved these changes
Mar 19, 2026
| quality: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 90 # TODO: need to reduce this after we figure out our testing strategy. | ||
| timeout-minutes: 180 |
Member
There was a problem hiding this comment.
should we keep the todo about eventually reducing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc PR
Type of PR
Description
Increase test timeout. Removed unnecessary print statements from default test hooks. You can still manually set the logger level back down by modifying the
hook-testinglogger.Testing