Stop documenting consecutive declarations#348
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #348 +/- ##
=======================================
Coverage 91.79% 91.79%
=======================================
Files 13 13
Lines 2609 2609
=======================================
Hits 2395 2395
Misses 214 214
🚀 New features to boost your workflow:
|
fingolfin
changed the title
Stop carrying declaration-scan state past the first declaration after an AutoDoc source comment block. This makes declaration documentation match the documented immediate-adjacency rule instead of implicitly attaching the same comment block to later consecutive declarations. Add a regression test for consecutive declarations and make the general worksheet fixture spell out the later category declarations explicitly so it no longer depends on the old buggy behavior. AI-assisted with Codex for implementation, test updates, and changelog entry. Fixes #169 Co-authored-by: Codex <codex@openai.com>
fingolfin
force-pushed
the
codex/fix-169-consecutive-declarations
branch
from
1dfcb07 to
8bdde58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop carrying declaration-scan state past the first declaration
after an AutoDoc source comment block. This makes declaration
documentation match the documented immediate-adjacency rule
instead of implicitly attaching the same comment block to later
consecutive declarations.
Add a regression test for consecutive declarations and make the
general worksheet fixture spell out the later category
declarations explicitly so it no longer depends on the old buggy
behavior.
AI-assisted with Codex for implementation, test updates, and
changelog entry.
Fixes #169
Co-authored-by: Codex codex@openai.com