Skip to content

Simplify declaration filter styles#346

Merged
fingolfin merged 1 commit intomasterfrom
codex/simplify-filter-style
Mar 11, 2026
Merged

Simplify declaration filter styles#346
fingolfin merged 1 commit intomasterfrom
codex/simplify-filter-style

Conversation

@fingolfin
Copy link
Member

Replace mixed has_filters sentinels with explicit filter styles.
Also cover the bare for case with a parser regression test.

AI-assisted with Codex for implementation and test updates.

Resolves #128 (I think)

Co-authored-by: Codex codex@openai.com

Replace mixed has_filters sentinels with explicit filter styles.
Also cover the bare for case with a parser regression test.

AI-assisted with Codex for implementation and test updates.

Resolves #128 (I think)

Co-authored-by: Codex <codex@openai.com>
@fingolfin fingolfin enabled auto-merge (squash) March 11, 2026 17:33
@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.74%. Comparing base (2c6a3f7) to head (d9ed5e5).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
+ Coverage   91.65%   91.74%   +0.08%     
==========================================
  Files          13       13              
  Lines        2600     2603       +3     
==========================================
+ Hits         2383     2388       +5     
+ Misses        217      215       -2     
Files with missing lines Coverage Δ
gap/Parser.gi 96.42% <100.00%> (+0.22%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin fingolfin merged commit 8502fe5 into master Mar 11, 2026
8 checks passed
@fingolfin fingolfin deleted the codex/simplify-filter-style branch March 11, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor the IsInt keys for filter scanning

1 participant