Skip to content

Allow entities in headings#344

Merged
fingolfin merged 1 commit intomasterfrom
codex/fix-issue-86-label-entities
Mar 11, 2026
Merged

Allow entities in headings#344
fingolfin merged 1 commit intomasterfrom
codex/fix-issue-86-label-entities

Conversation

@fingolfin
Copy link
Member

Sanitize chapter, section, and subsection labels before writing XML.
Apply the same normalization to explicit @...Label commands.
This keeps entity names in headings from producing invalid XML.

Fixes #86

AI-assisted with Codex for debugging, code edits, and tests.

Co-authored-by: Codex codex@openai.com

Sanitize chapter, section, and subsection labels before writing XML.
Apply the same normalization to explicit @...Label commands.
This keeps entity names in headings from producing invalid XML.

Fixes #86

AI-assisted with Codex for debugging, code edits, and tests.

Co-authored-by: Codex <codex@openai.com>
@fingolfin fingolfin enabled auto-merge (squash) March 11, 2026 17:01
@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.65%. Comparing base (a94e025) to head (0285e22).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #344   +/-   ##
=======================================
  Coverage   91.64%   91.65%           
=======================================
  Files          13       13           
  Lines        2597     2600    +3     
=======================================
+ Hits         2380     2383    +3     
  Misses        217      217           
Files with missing lines Coverage Δ
gap/DocumentationTree.gi 95.97% <100.00%> (+0.03%) ⬆️
gap/Parser.gi 96.20% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin fingolfin merged commit 2c6a3f7 into master Mar 11, 2026
8 checks passed
@fingolfin fingolfin deleted the codex/fix-issue-86-label-entities branch March 11, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Entities in section titles lead to error

1 participant