Merged
Conversation
Contributor
Author
|
I'll write some tests tihi |
Contributor
Author
|
Changed tests to always expect personal bookings to be unconfirmed and council bookings to be confirmed, irrespective of time (as per my spec, see pr comment). Also added some new tests. |
>24h booking unconfirm and so do moving by >24h
georgelgeback
approved these changes
Mar 27, 2026
Contributor
georgelgeback
left a comment
georgelgeback
left a comment
There was a problem hiding this comment.
I trust BilF that this booking logic is best for them. Code looks great. Sorry for the wait.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes based on my (Vic, BilF 25/26) opinions:
General bug fixes: