Skip to content

chore: unpin play-services-auth #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thatfiredev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: unpin play-services-auth #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ dependencies {
// Other Firebase/Play services deps
implementation("com.google.firebase:firebase-auth")

// Pinned to 20.7.0 as a workaround for issue https://github.com/firebase/quickstart-android/issues/1647
implementation("com.google.android.gms:play-services-auth:20.7.0")

// FirebaseUI (for authentication)
Expand Down
3 changes: 1 addition & 2 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ fun isNonStable(candidate: ModuleComponentIdentifier): Boolean {

fun isBlockListed(candidate: ModuleComponentIdentifier): Boolean {
return listOf(
"androidx.browser:browser",
"com.google.android.gms:play-services-auth"
"androidx.browser:browser"
).any { keyword ->
keyword in candidate.toString().lowercase()
}
Expand Down
Loading