migrate GitHub release auth to Secret Manager

[shettyvarun268]

This change updates the build configuration to fetch the GitHub release token from Google Cloud Secret Manager instead of decrypting the legacy [hub.enc] file with KMS. The hub CLI tool used in [publish.sh] will now authenticate using the GITHUB_TOKEN environment variable injected by [cloudbuild.yaml] The obsolete hub.enc file has been removed from the repository. This improves security and resolves recent authentication failures during the release process.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the GitHub release authentication mechanism within the Cloud Build configuration. It transitions from decrypting a legacy 'hub.enc' file using KMS to securely fetching the GitHub release token directly from Google Cloud Secret Manager. This change enhances security and addresses previous authentication failures during the release process by injecting the 'GITHUB_TOKEN' environment variable.

Highlights

• Authentication Migration: Migrated GitHub release authentication from decrypting a legacy 'hub.enc' file with KMS to securely fetching the GitHub token from Google Cloud Secret Manager.
• Security Enhancement: Improved the security posture by utilizing Google Cloud Secret Manager for managing the GitHub release token, reducing the exposure of sensitive credentials.
• Legacy Removal: Removed the obsolete 'hub.enc' file and the associated build steps for its decryption and credential setup, simplifying the build process.
• Build Configuration Update: Updated the 'cloudbuild.yaml' to inject the 'GITHUB_TOKEN' environment variable, sourced from Secret Manager, directly into the package publishing step.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• scripts/publish/cloudbuild.yaml
  • Removed the build step responsible for decrypting 'hub.enc' using KMS.
  • Eliminated the step that copied the decrypted 'hub' credentials to '~/.config/hub'.
  • Added 'secretEnv: ["GITHUB_TOKEN"]' to the 'package-builder' publish step.
  • Configured 'availableSecrets' to retrieve 'GITHUB_TOKEN' from Google Cloud Secret Manager.

Activity

• No human activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request migrates the GitHub release authentication from a KMS-encrypted file to Google Cloud Secret Manager. The changes in cloudbuild.yaml correctly remove the old decryption steps and integrate with Secret Manager using availableSecrets and secretEnv. This is a good security and maintainability improvement. I have one minor suggestion to improve file formatting.

[shettyvarun268]

/gemini review

[gemini-code-assist]

Code Review

This pull request successfully migrates the GitHub release authentication from KMS-encrypted hub.enc to Google Cloud Secret Manager. The changes correctly remove the old decryption and credential setup steps, and introduce the GITHUB_TOKEN environment variable injection via Secret Manager. This aligns with the stated goal of improving security and resolving authentication issues. The cloudbuild.yaml file is updated appropriately to reflect this new authentication mechanism.

[shettyvarun268]

/gemini review

[gemini-code-assist]

Code Review

This pull request migrates GitHub release authentication from using a KMS-encrypted file to fetching a token from Google Cloud Secret Manager. The changes in cloudbuild.yaml correctly remove the legacy decryption logic and introduce the use of availableSecrets to inject the GITHUB_TOKEN. This is a solid security improvement. I have one suggestion to make the new configuration more maintainable by using substitutions for the hardcoded secret path.

[inlined]

So much love