Skip to content

Remove @hidden annotations for custom resolvers.#1818

Merged
rosalyntan merged 4 commits intomasterfrom
rosalyntan.unhide
Mar 5, 2026
Merged

Remove @hidden annotations for custom resolvers.#1818
rosalyntan merged 4 commits intomasterfrom
rosalyntan.unhide

Conversation

@rosalyntan
Copy link
Member

Description

Code sample

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @rosalyntan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the extensibility of Firebase Data Connect by making previously internal GraphQL-related functions and interfaces publicly available. By removing @hidden annotations, developers can now more easily implement custom resolvers, thereby extending the capabilities of their GraphQL services. The change log has been updated to reflect this new capability.

Highlights

  • API Visibility: Removed @hidden JSDoc annotations from key GraphQL functions and interfaces, making them publicly accessible for custom resolver implementations.
  • Changelog Update: Updated the changelog to explicitly mention the addition of the onGraphRequest method, which supports custom resolvers for Firebase Data Connect.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • CHANGELOG.md
    • Updated changelog entry to reflect the addition of an onGraphRequest method for custom resolvers.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request exposes functionality for implementing custom resolvers for Firebase Data Connect by removing @hidden annotations from onGraphRequest and its related types (GraphqlServerOptions, FirebaseContext, GraphqlResolvers) in src/v2/providers/dataconnect/graphql.ts. The CHANGELOG.md has been updated to reflect the addition of the onGraphRequest method. The changes are consistent with the stated goal and appear correct.

@rosalyntan rosalyntan marked this pull request as ready for review February 25, 2026 01:17
Copy link
Contributor

@shettyvarun268 shettyvarun268 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rosalyntan rosalyntan added this pull request to the merge queue Mar 5, 2026
Merged via the queue into master with commit 85f84e7 Mar 5, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants