Skip to content

feat(auth): Add support for FPNV#942

Open
jonathanedey wants to merge 14 commits intomainfrom
fpnv
Open

feat(auth): Add support for FPNV#942
jonathanedey wants to merge 14 commits intomainfrom
fpnv

Conversation

@jonathanedey
Copy link
Collaborator

@jonathanedey jonathanedey commented Mar 23, 2026

Continues: #934

@jonathanedey jonathanedey added the release:stage Stage a release candidate label Mar 23, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates Firebase Phone Number Verification (FPNV) capabilities into the system. It provides a robust mechanism for validating FPNV JWTs, ensuring that applications can securely process tokens issued by the FPNV service. The implementation includes a dedicated service for token verification, a structured class for token claims, and detailed error handling, all backed by a thorough suite of tests.

Highlights

  • Firebase Phone Number Verification (FPNV) Support: Introduced a new module, firebase_admin/fpnv.py, to provide functionality for verifying Firebase Phone Number Verification (FPNV) JWTs.
  • Token Verification API: Added a verify_token function that allows users to validate FPNV tokens, performing checks for signature, expiration, audience, and issuer.
  • FpnvToken Class: Created an FpnvToken class to encapsulate the decoded claims of a verified FPNV token, providing convenient property access to common claims like phone_number, issuer, and audience.
  • Custom Error Handling: Implemented specific error classes, InvalidFpnvTokenError and ExpiredFpnvTokenError, to provide clear and precise feedback for various token validation failures.
  • Comprehensive Testing: Included a new test file, tests/test_fpnv.py, with extensive unit tests covering successful token verification, various invalid token scenarios, and proper error propagation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@google-cla
Copy link

google-cla bot commented Mar 23, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for Firebase Phone Number Verification (FPNV) by adding a new fpnv module. The implementation is well-structured, following existing patterns in the firebase-admin SDK, and includes a comprehensive set of tests. My review includes a few suggestions to improve code consistency with other modules and enhance the clarity of error messages for better debuggability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:stage Stage a release candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants