perf(storage): optimize dataset fetching with O(1) lookup#322
Open
beck-8 wants to merge 2 commits intofilecoin-project:masterfrom
Open
perf(storage): optimize dataset fetching with O(1) lookup#322beck-8 wants to merge 2 commits intofilecoin-project:masterfrom
beck-8 wants to merge 2 commits intofilecoin-project:masterfrom
Conversation
- Refactor getDetailedDataSet to use direct WarmStorageService.getDataSet() instead of fetching all datasets via listDataSets() - Add fast path in createStorageContext when dataSetId is explicitly provided, using createStorageContextFromDataSetId helper - Directly instantiate StorageContext to bypass SDK's expensive resolveByDataSetId which makes redundant RPC calls - Fetch metadata and provider info in parallel for better performance This significantly speeds up 'dataset show <id>' and 'add --data-set <id>' commands by avoiding O(N) dataset scanning and redundant RPC calls.
beck-8
force-pushed
the
perf/optimize-get-detailed-data-set
branch
from
a169dce to
1840f61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#321
This significantly speeds up 'dataset show ' and 'add --data-set ' commands by avoiding O(N) dataset scanning and redundant RPC calls.
This was generated for me by claude, and I tested it locally without any problems. If there is anything that does not comply with the specifications, you can directly submit and modify my PR.