reversed listener execution order to prevent issues with listener removal#35
Open
sodersys wants to merge 1 commit intoffrostfall:masterfrom
Open
reversed listener execution order to prevent issues with listener removal#35sodersys wants to merge 1 commit intoffrostfall:masterfrom
sodersys wants to merge 1 commit intoffrostfall:masterfrom
Conversation
…oval.
.wait() stores index as length of listeners.
if there's multiple waiting listeners, they will cause eachother's index to be offset when removed.
This will lead to loss non-temporary listeners.
by reversing execution order the possiblity of this is removed.
an example of this is below.
--shared
local bytenet = require(game.ReplicatedStorage.ByteNet)
return bytenet.defineNamespace("meow", function()
return {
meow = bytenet.definePacket({
value = bytenet.string
})
}
end)
--client
local mod = require(game.ReplicatedStorage.ModuleScript)
for i = 1, 2 do
task.spawn(function()
local tv = mod.meow.wait()
print(tv, i)
end)
end
--server
local m = require(game.ReplicatedStorage.ModuleScript)
m.meow.sendToAll("awa")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.wait() stores index as length of listeners.
if there's multiple waiting listeners, they will cause eachother's index to be offset when removed. This will lead to loss non-temporary listeners.
by reversing execution order the possiblity of this is removed.
an example of this is below.