WIP: merge Click and Typer functionality#1653
Draft
svlandeg wants to merge 9 commits intofastapi:drop-clickfrom
Draft
WIP: merge Click and Typer functionality#1653svlandeg wants to merge 9 commits intofastapi:drop-clickfrom
svlandeg wants to merge 9 commits intofastapi:drop-clickfrom
Conversation
svlandeg
changed the title
…e. WIP (tests failing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
Continue work from #1525 and #1601, vendoring Click.
At several places in Typer's codebase, we override/subclass Click's behaviour. This PR simplifies the code in these cases, as we don't need to keep legacy Click code around anymore.
In practice, this moves a lot of code around while also making edits to those code bits. It's probably slightly easier to review this PR commit-by-commit, though it'll still be somewhat rough to review.
0% vibe-coded, 100% manually-executed refactor to (try and) ensure high quality & reduce unexpected errors.
Checklist
Commandfunctionality from Typer & ClickGroupfunctionality from Typer & ClickParameteran abstract class in Typer's core moduleArgumentfunctionality from Typer & ClickOptionfunctionality from Typer & ClickPathfunctionality from Typer & ClickContextinto a separate Python moduleChoicefunctionality from Typer & Click_click.shell_completionandtyper._completion_classes