Workflows

[Coder-Harshit]

Pre-submission checklist

• I've ran the following linters locally and fixed lint errors related to the files I modified in this PR
  • black .
  • usort format .
  • flake8

Summary

Failed tests were the motivating factor to debug the problem.

[Coder-Harshit]

@arthaud could you please review the changes

[arthaud]

LGTM but it seems like you upgraded the react version in sapp/ui/frontend/package-lock.json so I need to double check that the UI still works.

[Coder-Harshit]

sure if there any other input required from my side, do tell!

[arthaud]

Glad I tried. This is indeed breaking the UI.

Running cd sapp/ui/frontend && npm run-script start gives a lot of errors:

Failed to compile.

Attempted import error: 'useQuery' is not exported from '@apollo/client' (imported as 'useQuery').
ERROR in ./src/Filter.js 103:6-14
export 'useQuery' (imported as 'useQuery') was not found in '@apollo/client' (possible exports: ApolloCache, ApolloClient, ApolloLink, CombinedGraphQLErrors, CombinedProtocolErrors, DocumentTransform, HttpLink, InMemoryCache, LinkError, LocalStateError, MissingFieldError, NetworkStatus, Observable, ObservableQuery, ServerError, ServerParseError, UnconventionalError, build, checkFetcher, concat, createHttpLink, createSignalIfSupported, defaultDataIdFromObject, defaultPrinter, disableExperimentalFragmentVariables, disableFragmentWarnings, empty, enableExperimentalFragmentVariables, execute, fallbackHttpConfig, from, gql, isNetworkRequestSettled, isReference, makeVar, parseAndCheckHttpResponse, resetCaches, rewriteURIForGET, selectHttpOptionsAndBody, selectHttpOptionsAndBodyInternal, selectURI, setLogVerbosity, split, version)

ERROR in ./src/Filter.js 147:10-18
export 'useQuery' (imported as 'useQuery') was not found in '@apollo/client' (possible exports: ApolloCache, ApolloClient, ApolloLink, CombinedGraphQLErrors, CombinedProtocolErrors, DocumentTransform, HttpLink, InMemoryCache, LinkError, LocalStateError, MissingFieldError, NetworkStatus, Observable, ObservableQuery, ServerError, ServerParseError, UnconventionalError, build, checkFetcher, concat, createHttpLink, createSignalIfSupported, defaultDataIdFromObject, defaultPrinter, disableExperimentalFragmentVariables, disableFragmentWarnings, empty, enableExperimentalFragmentVariables, execute, fallbackHttpConfig, from, gql, isNetworkRequestSettled, isReference, makeVar, parseAndCheckHttpResponse, resetCaches, rewriteURIForGET, selectHttpOptionsAndBody, selectHttpOptionsAndBodyInternal, selectURI, setLogVerbosity, split, version)

ERROR in ./src/Filter.js 166:6-14
export 'useQuery' (imported as 'useQuery') was not found in '@apollo/client' (possible exports: ApolloCache, ApolloClient, ApolloLink, CombinedGraphQLErrors, CombinedProtocolErrors, DocumentTransform, HttpLink, InMemoryCache, LinkError, LocalStateError, MissingFieldError, NetworkStatus, Observable, ObservableQuery, ServerError, ServerParseError, UnconventionalError, build, checkFetcher, concat, createHttpLink, createSignalIfSupported, defaultDataIdFromObject, defaultPrinter, disableExperimentalFragmentVariables, disableFragmentWarnings, empty, enableExperimentalFragmentVariables, execute, fallbackHttpConfig, from, gql, isNetworkRequestSettled, isReference, makeVar, parseAndCheckHttpResponse, resetCaches, rewriteURIForGET, selectHttpOptionsAndBody, selectHttpOptionsAndBodyInternal, selectURI, setLogVerbosity, split, version)

[truncated]

webpack compiled with 44 errors

Could you please revert your changes to sapp/ui/frontend/package.json and sapp/ui/frontend/package-lock.json?

Thanks for contributing :)