Add Swift code snippets to Fabric native component iOS documentation#4936
Open
AbhishekGiri04 wants to merge 3 commits intofacebook:mainfrom
Open
Add Swift code snippets to Fabric native component iOS documentation#4936AbhishekGiri04 wants to merge 3 commits intofacebook:mainfrom
AbhishekGiri04 wants to merge 3 commits intofacebook:mainfrom
Conversation
Fixes facebook#3679 Added a note clarifying that the standalone systrace tool has been removed from Android platform-tools and users should use Android Studio Profiler instead. This addresses confusion around the deprecated systrace command-line tool while maintaining the documentation for the Systrace API in React Native. Changes: - Added deprecation notice for standalone systrace tool - Clarified that Android Studio Profiler is the recommended alternative - Improved documentation clarity for developers migrating from systrace
- Added tabbed code examples (Objective-C/Swift) for iOS Fabric components - Implemented complete Swift version of RCTWebView class - Maintains consistency with Android documentation structure (Java/Kotlin tabs) - Fixes facebook#4897
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
hey, thanks for addressing the issue, this is core problem i face |
Contributor
Author
|
Thanks @divyanshu-patil! I kept this PR focused on fixing #4897 by adding Swift equivalents to existing examples. For additional examples beyond WebView, I'd suggest opening a separate issue to discuss with maintainers which components would be most valuable. @facebook/react-native-team - Ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Swift code examples to the Fabric native component iOS documentation, providing Swift developers with clear implementation examples alongside existing Objective-C code.
Motivation
Fixes #4897
The current documentation only shows Objective-C examples for iOS Fabric native components, while Android documentation provides both Java and Kotlin options. This creates a gap for Swift developers who may not be familiar with Objective-C syntax.
Changes
docs/fabric-native-components-ios.mdRCTWebViewclass with modern Swift patterns@objcannotationsTest Plan