Fix minor issues in the Turbo Modules iOS doc#4892
Open
sepeth wants to merge 1 commit intofacebook:mainfrom
Open
Fix minor issues in the Turbo Modules iOS doc#4892sepeth wants to merge 1 commit intofacebook:mainfrom
sepeth wants to merge 1 commit intofacebook:mainfrom
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
Main issue was that instead of
open TurboModuleExample.xcworkspace,open SampleApp.xcworkspacewas used.NS_ASSUME_NONNULL_END should already be existing in the file, but I made the mistake of clicking the copy button at the top when viewing the docs, and pasting directly into the file. Given that it is just one more line, it wouldn't hurt to have it in the diff.
And, I have a question, I see some copies of this in the
website/versioned_docs/**/*as well, should I update those as well, or is there a script/automation that does this?