-
Notifications
You must be signed in to change notification settings - Fork 171
Use auth code flow #3398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use auth code flow #3398
Conversation
143f0d9 to
cfe2bcd
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3398 +/- ##
==========================================
- Coverage 52.30% 52.26% -0.03%
==========================================
Files 804 804
Lines 33421 33450 +29
Branches 6972 6975 +3
==========================================
+ Hits 17478 17480 +2
- Misses 14555 15885 +1330
+ Partials 1388 85 -1303 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Subscribed to pull request
Generated by CodeMention |
CHANGELOG.md
Outdated
|
|
||
| ### 🎉 New features | ||
|
|
||
| - Use authorization code flow with PKCE for browser-based login. ([#XXXX](https://github.com/expo/eas-cli/pull/XXXX) by [@byronkarlen](https://github.com/byronkarlen)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
XXXX?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops thank you! (geez claude)
cfe2bcd to
4b6aafd
Compare
|
✅ Thank you for adding the changelog entry! |
Why
Browser-based login should get a code and then exchange that code for a session_secret.
How
Used new auth flow provided by website/www. Uses state, code_challenge and code_verifier like OAuth 2.1.
Test Plan
Tested locally against expo.test with https://github.com/expo/universe/pull/24960
Made sure:
Tested against expo.dev as well. Tried to test SSO but was hard since our stub-idp doesn't save state/users.