fix: print API error message instead of operation nil#821
Open
mlec1 wants to merge 1 commit intoexoscale:masterfrom
Open
fix: print API error message instead of operation nil#821mlec1 wants to merge 1 commit intoexoscale:masterfrom
mlec1 wants to merge 1 commit intoexoscale:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Exactly like in #806, it returns
operation is nilwhen update a SKSNodePool when it is called with parameters that the API rejects.exo compute sks nodepool update itops-test itops-test-workers --label managed_uptime=standard --label dont_manage_until=2026-05-06 --label test=test/testAt the opposite of #806, I didn't add a e2e test because I encountered the issue while trying to add a
/in a label of a SKS Nodepool but at the end I would like that it works (I made a support ticket for this), so if I make a E2E test for it now, it might not pass anymore once/are accepted on the API Side.Checklist
(For exoscale contributors)
CHANGELOG.md)Testing
Now returns the BAD Request response from the API.