fix env_vars: preprend_path and append_path were doing the opposite#285
Open
albestro wants to merge 2 commits intoeth-cscs:mainfrom
Open
fix env_vars: preprend_path and append_path were doing the opposite#285albestro wants to merge 2 commits intoeth-cscs:mainfrom
albestro wants to merge 2 commits intoeth-cscs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes envvars prepend/append behavior. Indeed, it was doing the exact opposite, i.e. prepending vars specified under
append_pathand appending vars underprepend_path.The actual fix is just the first commit 5a1d620, but I also took the chance to refactor the code aiming at better isolation for testing purposes.