This repository was archived by the owner on Nov 14, 2020. It is now read-only.
Additional checking for Devise-based forms#4
Open
nahue wants to merge 4 commits intoeploko:masterfrom
Open
Conversation
Owner
There was a problem hiding this comment.
Hm... do I get it right that if an app sets a flash message before rendering the form, the form would be considered filled in incorrectly and the submit button will display the retry message? I guess the flash messages can't be treaded as errors per se, what do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Devise forms outputs like "simple_form_for :user" so previously bound_to_model? returned false. Now its working ok.