Conversation
|
Play this branch at https://play.threadbare.game/branches/endlessm/champ-reorder-scenes. (This launches the game from the start, not directly at the change(s) in this pull request.) |
felixwalberg
left a comment
felixwalberg
left a comment
There was a problem hiding this comment.
This should be all set, as long as those 3 ext_resource deletions in the champ_stealth.tscn file are important.
There was a problem hiding this comment.
I personally think it is very confusing that 1_stealth comes after 3_sequence_puzzle. I suggest renumbering all the folders in the champ/ folder so that they are in gameplay order.
There was a problem hiding this comment.
If you rename resources in Godot (as opposed to your file manager), then (I believe) any references will be updated when you hit save. But in fact what is stored in the .tscn files when linking scenes in this way is the UID of the target scene - which does not change.
There was a problem hiding this comment.
Made this change, but I am going to have to go back and deal with merge conflicts. I am also noticing the zoom of the camera feels different. More of the tilemap (and the gray background) is visible, particularly in the intro/outro.
There was a problem hiding this comment.
Sorry, bad recommendation from me. Revert the rename, so the branch can be merged; then rename in a new branch.
There was a problem hiding this comment.
git revert e4fb403f370a72177fa1debc0b97e1e527b64d46
git push
There was a problem hiding this comment.
The zoom will not be anything to do with this branch.
There was a problem hiding this comment.
Commit reverted! After the team has got some other changes merged in I will look at adjusting tilemaps for the camera.
3 participants
Scene navigation triggers have been adjusted for the Champ storyquest to go in the following order:
1: Intro
2: Combat
3: Sequence Puzzle
4: Stealth
5: Outro