Prefix template scene root nodes with quest name #1912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
wjt
force-pushed
the
wjt/prefix-template-scene-root-nodes-with-quest-name
branch
from
5074d74 to
98e141a
Compare
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/prefix-template-scene-root-nodes-with-quest-name. (This launches the game from the start, not directly at the change(s) in this pull request.) |
manuq
approved these changes
Feb 11, 2026
Comment on lines
+106
to
+107
| var pascal_case_name := quest_name.capitalize().replace(" ", "") | ||
| scene.name = pascal_case_name + suffix |
For all scenes in the NO_EDIT template, change the root node name to be NoEdit followed by the quest name, matching the filename. When instantiating the template, rewrite the root node name to replace NoEdit with the PascalCase name of the quest, so that, again, the root node matches the filename. Resolves #1911
wjt
force-pushed
the
wjt/prefix-template-scene-root-nodes-with-quest-name
branch
from
98e141a to
0d82761
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all scenes in the NO_EDIT template, change the root node name to be NoEdit followed by the quest name, matching the filename.
When instantiating the template, rewrite the root node name to replace NoEdit with the PascalCase name of the quest, so that, again, the root node matches the filename.
Resolves #1911