Fix: Prevent query parameter corruption in base_url#3760
Open
veeceey wants to merge 1 commit intoencode:masterfrom
Open
Fix: Prevent query parameter corruption in base_url#3760veeceey wants to merge 1 commit intoencode:masterfrom
veeceey wants to merge 1 commit intoencode:masterfrom
Conversation
…ement When a base_url contained query parameters, _enforce_trailing_slash() was appending a slash to the entire raw_path (including the query string), which corrupted the query parameter values. For example: - Before: base_url="https://api.com?data=1" became "https://api.com?data=1/" (query param corrupted to "data=1/" instead of "data=1") - After: base_url="https://api.com?data=1" becomes "https://api.com/?data=1" (query param correctly preserved as "data=1") The fix splits the raw_path into path and query components, adds the trailing slash only to the path portion, then recombines them. Fixes encode#3614
Author
|
All CI passing on Python 3.9-3.13, ready for merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3614
When a
base_urlcontains query parameters, the trailing slash enforcement was corrupting the query parameter values by appending the slash to the query string instead of just the path.Problem
The
_enforce_trailing_slash()method was appending/to the entireraw_path, which includes both the path and query string. For a URL like/get?data=1, this became/get?data=1/, corrupting the query parameter value.Solution
Modified
_enforce_trailing_slash()in_client.pyto:raw_pathinto path and query components (using?as delimiter)Examples
base_url with query parameters:
base_url with trailing slash and query:
base_url without query (unchanged behavior):
Testing
tests/client/test_client.py