[Bazel] Replace uses of deprecated bazel_tools things#1682
Open
stevenlr wants to merge 1 commit intoemscripten-core:mainfrom
Open
[Bazel] Replace uses of deprecated bazel_tools things#1682stevenlr wants to merge 1 commit intoemscripten-core:mainfrom
stevenlr wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
reviewed
Feb 26, 2026
1c02d0d to
a2e4fcb
Compare
All C++ infrastructure should come from @rules_cc now.
a2e4fcb to
1ac99d2
Compare
sbc100
approved these changes
Feb 26, 2026
Contributor
Author
|
I believe the test failure here was just a flake, it seems the download of a Baze module failed somehow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the C++ rules, libraries and utilities from bazel_tools is being deprecated in favor of using rules_cc.
Similarly the@bazel_tools//src/conditions:host_windowsconstraint has been deprecated for a while and will be removed with Bazel 10.