bazel: update rules_nodejs and migrate to rules_js#1436
Merged
walkingeyerobot merged 3 commits intoemscripten-core:mainfrom Dec 5, 2024
eric-higgins-ai:main
Merged
bazel: update rules_nodejs and migrate to rules_js#1436walkingeyerobot merged 3 commits intoemscripten-core:mainfrom eric-higgins-ai:main
walkingeyerobot merged 3 commits intoemscripten-core:mainfrom
eric-higgins-ai:main
Conversation
eric-higgins-ai
changed the title
Contributor
Author
|
@walkingeyerobot bump on a review here |
Collaborator
|
Apologies, this slipped past me somehow. Thank you for pinging me on this, and thank you for the contribution. I'm unfamiliar with aspect-build and a bit hesitant to accept dependencies. I'll spend some time this week reading their code and docs and such to get a little familiar with it before accepting this PR. It's very likely I end up approving this after learning a bit more about it. |
walkingeyerobot
approved these changes
Dec 5, 2024
Collaborator
walkingeyerobot
left a comment
walkingeyerobot
left a comment
There was a problem hiding this comment.
aspect is fine to use
mmorel-35
pushed a commit
to mmorel-35/emsdk
that referenced
this pull request
Feb 3, 2026
) This finishes the work started in emscripten-core#1388 by fixing CI. It avoids a breaking change by: * Using the latest rules_js 1.x.x version, instead of updating to rules_js 2 (which removes support for bazel 5). * Copying the contents of [rules_js_dependencies](https://github.com/aspect-build/rules_js/blob/main/js/repositories.bzl) instead of calling it, as the call would need to be added by users in their `WORKSPACE` files Context from the previous PR: > Bazel's Node.js dependency comes from [rules_nodejs](https://github.com/bazelbuild/rules_nodejs/). Previously, bazel/deps.bzl was using rules_nodejs 5.8.0, released in 2022 and only supported Node.js toolchains up to 18.12.1. > This PR bumps rules_nodejs to latest 6.1.1. It also replaces build_bazel_rules_nodejs with [rules_js](https://github.com/aspect-build/rules_js), since npm_install that bazel/emscripten_deps.bzl used was deprecated. The README of rules_nodejs now recommends migrating to rules_js for everything other than the Node.js toolchain: (bazel-contrib/rules_nodejs@371e8ca) > Impetus Our repo builds with Bazel and uses Emscripten and Node.js. Tried to upgrade Node.js 18 to Node.js 20 and saw that emsdk didn't support rules_nodejs 6+ in the same workspace. Similarly, it's not possible to update to rules_js v2 in a workspace that also references `emsdk`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This finishes the work started in #1388 by fixing CI. It avoids a breaking change by:
WORKSPACEfilesContext from the previous PR:
Similarly, it's not possible to update to rules_js v2 in a workspace that also references
emsdk.