[EH] Add more explanation to EXPORT_EXCEPTION_HANDLING_HELPERS deprecation#26517
Merged
aheejin merged 4 commits intoemscripten-core:mainfrom Mar 21, 2026
Merged
[EH] Add more explanation to EXPORT_EXCEPTION_HANDLING_HELPERS deprecation#26517aheejin merged 4 commits intoemscripten-core:mainfrom
aheejin merged 4 commits intoemscripten-core:mainfrom
Conversation
…ation Like WebAssembly/binaryen#8507, there can be people who use this methods at `-O1` or above. This adds more explanation of the workaround in ChangeeLog, site docs, and the deprecation message. You don't strictly need `decrementExceptionRefcount` to use `getExceptionMessage`, but you need it if you care about asan, because exceptions thrown in Wasm and caught in JS don't get freed unless you explicitly decrement the refcount.
Member
Author
|
Come to think of it, I'm not sure if it was really a good idea to deprecate the setting, because there may be more people who use those methods at |
aheejin
changed the title
sbc100
approved these changes
Mar 21, 2026
Member
Author
|
Any opinions on the deprecation itself? |
Collaborator
|
I don't feel too strongly since I don't think many folks will be likely using this setting. If just exporting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like WebAssembly/binaryen#8507, there can be people who use this methods at
-O1or above. This adds more explanation of the workaround in ChangeeLog, site docs, and the deprecation message. You don't strictly needdecrementExceptionRefcountto usegetExceptionMessage, but you need it if you care about asan, because exceptions thrown in Wasm and caught in JS don't get freed unless you explicitly decrement the refcount.