Fix JSEvents deferredCalls sort comparator. NFC#26516
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Mar 21, 2026
Merged
Fix JSEvents deferredCalls sort comparator. NFC#26516sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
Use numeric subtraction so sort orders by precedence; a boolean comparator does not satisfy Array.prototype.sort's contract.
sbc100
approved these changes
Mar 21, 2026
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
Thanks for fix!
BTW, is bug effecting the programs you are building? I.e. are you relying on this HTML5_SUPPORT_DEFERRING_USER_SENSITIVE_REQUESTS mechanism yourself?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use numeric subtraction so sort orders by precedence; a boolean comparator does not satisfy Array.prototype.sort's contract.